feat: add automated deployment and validation scripts and workflows#116
Draft
feat: add automated deployment and validation scripts and workflows#116
Conversation
ZenGround0
reviewed
Aug 6, 2025
Collaborator
ZenGround0
left a comment
ZenGround0
left a comment
There was a problem hiding this comment.
There are a few things to resolve before merging this
| fi | ||
|
|
||
| # Test 9: PDPVerifier implementation address | ||
| if implementation=$(get_proxy_implementation "$PDP_VERIFIER_ADDRESS"); then |
Collaborator
There was a problem hiding this comment.
These implementation checks are not useful if we remove reporting of implementation addr.
A potentially useful thing is to check that the contract code of the implementation matches the expected. For that you'd
- get the implementation addr from get_proxy_implementation
- check that its code cid matched pdp verifier
ZenGround0
approved these changes
Aug 7, 2025
github-project-automation
bot
moved this from 🔎 Awaiting review
to ✔️ Approved by reviewer
in FOC
feat: add automated deployment and validation scripts and workflows
fix: add address validation and better error handling
chore: update succesful deployment issue text
chore: update schedule
Renames `CALIBNET_KEYSTORE_JSON` to `CALIBNET_KEYSTORE_B64`
fix: update timeout to blocktime
chore: remove no longer valid tests
fix: update deployment parameters
rjan90
force-pushed
the
phi/post-deployment-script
branch
from
a5a5943 to
638a33c
Compare
Collaborator
Author
|
Okay, I have rebased this onto the latest changes in main. Will do a quick sanity check in my fork before merging |
Contributor
|
@rjan90 : what are you thinking to do here? Is this still relevant or close and reengage when we get more of our deployment process ironed out? |
Contributor
|
@rjan90 : I'm putting this back to triage to decide next steps. |
Collaborator
Author
|
Will convert to draft until next steps are flushed out |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #106
Covers some items in #118
Description
This PR adds a workflow for daily deployments of contracts, as well as validation. It is using the pre-funded address here: 0xD1E43422236C921A6172982caFe142F1E9668e52 for deployment of the contracts.
I have added the secrets (
CALIBNET_KEYSTORE_JSON,CALIBNET_KEYSTORE_PASSWORDandCALIBNET_RPC_URL) to the action secrets and variables, so this should be working properly now.The workflow has been tested in my fork here: https://github.com/rjan90/filecoin-services/actions/workflows/scheduled-deployment.yml